The following document contains the results of FindBugs Report
FindBugs Version is 2.0.2
Threshold is medium
Effort is min
Classes | Bugs | Errors | Missing Classes |
---|---|---|---|
326 | 99 | 0 | 0 |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in kernel.storage.TimestampedRepositoryReader.loadProperties(): new java.io.FileReader(File) | I18N | DM_DEFAULT_ENCODING | 107 | High |
Found reliance on default encoding in kernel.storage.TimestampedRepositoryReader.saveProperties(): new java.io.FileWriter(File) | I18N | DM_DEFAULT_ENCODING | 117 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in kernel.storage.TimestampedRepositoryReader$ProcessedChunkFileFilter.loadProperties(): new java.io.FileReader(File) | I18N | DM_DEFAULT_ENCODING | 215 | High |
kernel.storage.TimestampedRepositoryReader$ProcessedChunkFileFilter.loadProperties() may fail to clean up java.io.Reader | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 215 | Medium |
kernel.storage.TimestampedRepositoryReader$ProcessedChunkFileFilter.loadProperties() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 215 | Medium |
Should kernel.storage.TimestampedRepositoryReader$ProcessedChunkFileFilter be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 194 | Medium |
Unread field: kernel.storage.TimestampedRepositoryReader$ProcessedChunkFileFilter.force | PERFORMANCE | URF_UNREAD_FIELD | 206 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
kernel.system.GalaxyStorageImpl.close() does not release lock on all paths | MT_CORRECTNESS | UL_UNRELEASED_LOCK | 119 | High |
kernel.system.GalaxyStorageImpl.close(int) does not release lock on all paths | MT_CORRECTNESS | UL_UNRELEASED_LOCK | 194 | High |
kernel.system.GalaxyStorageImpl.commit(int) does not release lock on all paths | MT_CORRECTNESS | UL_UNRELEASED_LOCK | 249 | High |
kernel.system.GalaxyStorageImpl.open(String) does not release lock on all paths | MT_CORRECTNESS | UL_UNRELEASED_LOCK | 147 | High |
kernel.system.GalaxyStorageImpl.write(int, byte[], int, int) does not release lock on all paths | MT_CORRECTNESS | UL_UNRELEASED_LOCK | 222 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
exceptional return value of java.io.File.delete() ignored in org.egothor.dir.GalaxyIndexCleaner.findOldestConstFileCreationTime() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 182 | Medium |
Write to static field org.egothor.dir.GalaxyIndexCleaner.location from instance method new org.egothor.dir.GalaxyIndexCleaner(String, String) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 41 | High |
Write to static field org.egothor.dir.GalaxyIndexCleaner.lockServerConfigFilename from instance method new org.egothor.dir.GalaxyIndexCleaner(String, String) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 42 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Inconsistent synchronization of org.egothor.dir.SharedRepositoryTanker.indexConstPeriodOfTime; locked 66% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 1059 | Medium |
Inconsistent synchronization of org.egothor.dir.SharedRepositoryTanker.indexTimestamp; locked 83% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 1092 | Medium |
Inconsistent synchronization of org.egothor.dir.SharedRepositoryTanker.localTanker; locked 89% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 887 | Medium |
Inconsistent synchronization of org.egothor.dir.SharedRepositoryTanker.lockManager; locked 76% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 1037 | Medium |
Inconsistent synchronization of org.egothor.dir.SharedRepositoryTanker.removeDocsFile; locked 87% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 1203 | Medium |
Inconsistent synchronization of org.egothor.dir.SharedRepositoryTanker.removeDocsStream; locked 71% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 1198 | Medium |
Inconsistent synchronization of org.egothor.dir.SharedRepositoryTanker.threadGroupId; locked 62% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 1052 | Medium |
Load of known null value in org.egothor.dir.SharedRepositoryTanker.processLocalBarrel(Barrel) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 649 | Medium |
exceptional return value of java.io.File.delete() ignored in org.egothor.dir.SharedRepositoryTanker.destroy() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 928 | Medium |
exceptional return value of java.io.File.delete() ignored in org.egothor.dir.SharedRepositoryTanker.removeSelectedDocuments() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 736 | Medium |
Unread field: org.egothor.dir.SharedRepositoryTanker.lockServerConfigFilename | PERFORMANCE | URF_UNREAD_FIELD | 162 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from Thread to org.galaxy.utils.NotifyingThread in org.galaxy.connectors.AbstractConnector.handleComplete(Thread) | STYLE | BC_UNCONFIRMED_CAST | 177 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unread public/protected field: org.galaxy.connectors.AbstractTaskExecutor.failed | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 96 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.galaxy.connectors.bobo.ClientDownloadTaskBody.getStart() may expose internal representation by returning ClientDownloadTaskBody.start | MALICIOUS_CODE | EI_EXPOSE_REP | 56 | Medium |
org.galaxy.connectors.bobo.ClientDownloadTaskBody.setStart(String[]) may expose internal representation by storing an externally mutable object into ClientDownloadTaskBody.start | MALICIOUS_CODE | EI_EXPOSE_REP2 | 60 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.galaxy.connectors.bobo.CrawlerSystemComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 11 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.galaxy.connectors.bobo.MassiveDownloadTaskBody.getStart() may expose internal representation by returning MassiveDownloadTaskBody.start | MALICIOUS_CODE | EI_EXPOSE_REP | 113 | Medium |
org.galaxy.connectors.bobo.MassiveDownloadTaskBody.setStart(String[]) may expose internal representation by storing an externally mutable object into MassiveDownloadTaskBody.start | MALICIOUS_CODE | EI_EXPOSE_REP2 | 123 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.galaxy.connectors.bobo.cabinets.TaskBody.getDomain() may expose internal representation by returning TaskBody.domain | MALICIOUS_CODE | EI_EXPOSE_REP | 165 | Medium |
org.galaxy.connectors.bobo.cabinets.TaskBody.getStart() may expose internal representation by returning TaskBody.start | MALICIOUS_CODE | EI_EXPOSE_REP | 149 | Medium |
org.galaxy.connectors.bobo.cabinets.TaskBody.getValid() may expose internal representation by returning TaskBody.valid | MALICIOUS_CODE | EI_EXPOSE_REP | 157 | Medium |
org.galaxy.connectors.bobo.cabinets.TaskBody.setDomain(String[]) may expose internal representation by storing an externally mutable object into TaskBody.domain | MALICIOUS_CODE | EI_EXPOSE_REP2 | 169 | Medium |
org.galaxy.connectors.bobo.cabinets.TaskBody.setStart(String[]) may expose internal representation by storing an externally mutable object into TaskBody.start | MALICIOUS_CODE | EI_EXPOSE_REP2 | 153 | Medium |
org.galaxy.connectors.bobo.cabinets.TaskBody.setValid(String[]) may expose internal representation by storing an externally mutable object into TaskBody.valid | MALICIOUS_CODE | EI_EXPOSE_REP2 | 161 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Read of unwritten field symlinx in org.galaxy.connectors.filesystem.DirectoryTreeReader$FileSystemIterator.alreadyIndexed(File) | CORRECTNESS | NP_UNWRITTEN_FIELD | 235 | Medium |
Unwritten field: org.galaxy.connectors.filesystem.DirectoryTreeReader$FileSystemIterator.symlinx | CORRECTNESS | UWF_UNWRITTEN_FIELD | 235 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in org.galaxy.connectors.filesystem.HtaccessReader.process(DataInputStream): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 33 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.galaxy.db.PoolingDataSourceProvider.SUPPORTED_DRIVERS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 47 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.galaxy.distant.BoboConnectorImpl.getSupportedTaskTypes() may expose internal representation by returning BoboConnectorImpl.DEFAULT_SUPPORTED_TASK_TYPES | MALICIOUS_CODE | EI_EXPOSE_REP | 167 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to dataSource in org.galaxy.distant.CollectionsManagerImpl.getDataSourceLatestTaskReport(int, int) | STYLE | DLS_DEAD_LOCAL_STORE | 405 | Medium |
Dead store to dataSource in org.galaxy.distant.CollectionsManagerImpl.getDataSourceTaskSummaryReport(int, int) | STYLE | DLS_DEAD_LOCAL_STORE | 414 | Medium |
Dead store to dataSource in org.galaxy.distant.CollectionsManagerImpl.listDataSourceTaskReports(int, int, int, int, String, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 423 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.galaxy.distant.FileSystemConnectorImpl.getSupportedTaskTypes() may expose internal representation by returning FileSystemConnectorImpl.DEFAULT_SUPPORTED_TASK_TYPES | MALICIOUS_CODE | EI_EXPOSE_REP | 71 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
new org.galaxy.distant.ReplicableStorageImpl(DistantParameter[]) may expose internal representation by storing an externally mutable object into ReplicableStorageImpl.parameters | MALICIOUS_CODE | EI_EXPOSE_REP2 | 151 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.galaxy.distant.ReplicableStorageImpl$BootHelper be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 466 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in org.galaxy.distant.WaybackImpl.getDetailAsOfflineView(int, int, long, boolean, String): new String(byte[]) | I18N | DM_DEFAULT_ENCODING | 201 | High |
Found reliance on default encoding in org.galaxy.distant.WaybackImpl.getDetailAsOfflineView(int, int, long, boolean, String): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 208 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.galaxy.egothor.BufferedTankerProvider$BufferedTankerAdapter be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 40 | Medium |
Unread field: org.galaxy.egothor.BufferedTankerProvider$BufferedTankerAdapter.collectionId | PERFORMANCE | URF_UNREAD_FIELD | 52 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.galaxy.egothor.DataRepositoryAdapter$Elements be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 134 | Medium |
Unread field: org.galaxy.egothor.DataRepositoryAdapter$Elements.cache | PERFORMANCE | URF_UNREAD_FIELD | 143 | Medium |
Unread field: org.galaxy.egothor.DataRepositoryAdapter$Elements.cacheSize | PERFORMANCE | URF_UNREAD_FIELD | 137 | Medium |
Unread field: org.galaxy.egothor.DataRepositoryAdapter$Elements.cursor | PERFORMANCE | URF_UNREAD_FIELD | 142 | Medium |
Unused field: org.galaxy.egothor.DataRepositoryAdapter$Elements.current | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.galaxy.egothor.SimpleTankerProvider$SimpleTankerAdapter be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 40 | Medium |
Unread field: org.galaxy.egothor.SimpleTankerProvider$SimpleTankerAdapter.collectionId | PERFORMANCE | URF_UNREAD_FIELD | 52 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.galaxy.egothor.Tokens$Bitmap be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 16 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.galaxy.egothor.Tokens$Range be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 47 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
exceptional return value of java.io.File.mkdirs() ignored in org.galaxy.graph.ChunkManager.openChunk() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 133 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.galaxy.graph.GraphPostgreImpl.commit() passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 366 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.galaxy.processing.ProcessableResource$Fields be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 17 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.galaxy.processing.ProcessableResourceRemoteWorkerImpl is Externalizable but doesn't define a void constructor | BAD_PRACTICE | SE_NO_SUITABLE_CONSTRUCTOR_FOR_EXTERNALIZATION | 30 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Inconsistent synchronization of org.galaxy.processing.processor.AbstractProcessReport.reports; locked 83% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 62 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Load of known null value in org.galaxy.processing.processor.CharsetEncodingDetector.process(ProcessableResource) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 102 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Possible null pointer dereference of ContentTypeIndexFilter.implicitTypes in org.galaxy.processing.processor.ContentTypeIndexFilter.canFilter(ProcessableResource) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 72 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in org.galaxy.processing.processor.DeepWebDetector.process(ProcessableResource): new String(byte[]) | I18N | DM_DEFAULT_ENCODING | 164 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.galaxy.processing.processor.Indexer$WaybackIndexedFlagUpdater be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 489 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in org.galaxy.processing.processor.LinksExtractor.process(ProcessableResource): new String(byte[]) | I18N | DM_DEFAULT_ENCODING | 139 | High |
Can't close LinksExtractor.graph since it is always null in org.galaxy.processing.processor.LinksExtractor.uninstall() | CORRECTNESS | NP_CLOSING_NULL | 219 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.galaxy.processing.processor.TextExtractor$FakeDetector be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 188 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unused public or protected field: org.galaxy.run.AbstractStarter.configuration | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in org.galaxy.run.Checker.checkBerkeley(): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 105 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Boxed value is unboxed and then immediately reboxed in org.galaxy.utils.Configuration.getBoolean(String, boolean) | PERFORMANCE | BX_UNBOXING_IMMEDIATELY_REBOXED | 96 | Medium |
Boxed value is unboxed and then immediately reboxed in org.galaxy.utils.Configuration.getInteger(String, int) | PERFORMANCE | BX_UNBOXING_IMMEDIATELY_REBOXED | 77 | Medium |
Boxed value is unboxed and then immediately reboxed in org.galaxy.utils.Configuration.getLong(String, long) | PERFORMANCE | BX_UNBOXING_IMMEDIATELY_REBOXED | 58 | Medium |
org.galaxy.utils.Configuration.getBoolean(String) has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 90 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in org.galaxy.utils.DiffUtils.main(String[]): new java.io.FileWriter(String) | I18N | DM_DEFAULT_ENCODING | 2513 | High |
org.galaxy.utils.DiffUtils.patch_addPadding(LinkedList) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 2062 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.galaxy.utils.MD5.close() may expose internal representation by returning MD5.state | MALICIOUS_CODE | EI_EXPOSE_REP | 220 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in org.galaxy.utils.XmlBinder.read(Class, String): new java.io.FileReader(String) | I18N | DM_DEFAULT_ENCODING | 62 | High |
Found reliance on default encoding in org.galaxy.utils.XmlBinder.write(Object, Class, String): new java.io.FileWriter(String) | I18N | DM_DEFAULT_ENCODING | 34 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in org.galaxy.wayback.UUIDComputer.fromReference(String): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 25 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.galaxy.wayback.WaybackDatabaseImpl$Queries be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 835 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.galaxy.wayback.content.HTMLContentSimplifier$Attributes.COMMONS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 37 | Medium |
org.galaxy.wayback.content.HTMLContentSimplifier$Attributes.HREF should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 52 | Medium |
org.galaxy.wayback.content.HTMLContentSimplifier$Attributes.IMG should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 59 | Medium |
org.galaxy.wayback.content.HTMLContentSimplifier$Attributes.LINK should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 44 | Medium |
org.galaxy.wayback.content.HTMLContentSimplifier$Attributes.META should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 67 | Medium |
org.galaxy.wayback.content.HTMLContentSimplifier$Attributes.STYLE should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 74 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unread field: org.galaxy.wayback.content.HTMLOfflineContentPrinter.disableStyles | PERFORMANCE | URF_UNREAD_FIELD | 56 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Switch statement found in org.galaxy.wayback.content.InternalReferencesResolver.processElement(QName, XMLAttributes, Augmentations) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 91 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Switch statement found in org.galaxy.wayback.content.ReferencesParser$MyWriter.startElement(QName, XMLAttributes, Augmentations) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 158 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unread field: org.galaxy.wayback.content.filters.HtmlContentWriter.baseUrl | PERFORMANCE | URF_UNREAD_FIELD | 20 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Switch statement found in org.galaxy.wayback.content.filters.InternalReferencesResolver.processElement(QName, XMLAttributes, Augmentations) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 88 | Medium |